Enable docs on dist-x86_64-musl#74871
Merged
Conversation
Add the rust-docs component to toolchain x86_64-unknown-linux-musl, which allows people using rustup on their musl-based linux distribution to download the rust-docs.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
musl is at 1h 7m currently, at least based off of one build, so I think it should be fine to merge this since we're at an overall ceiling of around 2 hours. @bors r+ |
Collaborator
|
📌 Commit b5d143b has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit b5d143b with merge 022af3a6dc0dc3137483b41e581dbdaeea49fa2a... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Author
Collaborator
|
@Etherealist: 🔑 Insufficient privileges: not in try users |
Member
|
@bors retry Cargo spurious test failure? cc @ehuss |
bors
added
S-waiting-on-bors
Contributor
|
Thanks for the ping! That error has been fixed yesterday via #74923 (rust-lang/cargo#8559). |
Collaborator
|
⌛ Testing commit b5d143b with merge a932dedafa960cf337e78bd4b01e07ada47a3a05... |
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Collaborator
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Contributor
rust-lang/homu#75 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#74751 (Clean up E0730 explanation) - rust-lang#74782 (Don't use "weak count" around Weak::from_raw_ptr) - rust-lang#74835 (Clean up E0734 explanation) - rust-lang#74871 (Enable docs on dist-x86_64-musl) - rust-lang#74905 (Avoid bool-like naming) - rust-lang#74907 (Clean up E0740 explanation) - rust-lang#74915 (rustc: Ignore fs::canonicalize errors in metadata) - rust-lang#74934 (Improve diagnostics when constant pattern is too generic) - rust-lang#74951 (Cherry-pick the release notes for 1.45.1) Failed merges: r? @ghost
ghost
mentioned this pull request
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 4, 2020
…imulacrum Enable docs on in the x86_64-unknown-linux-musl manifest Add the rust-docs component to toolchain x86_64-unknown-linux-musl, which allows people using rustup on their musl-based linux distribution to download the rust-docs. Generating and uploading the docs was enabled in b5d143b (rust-lang#74871). In rust-lang#75102 @Mark-Simulacrum found that we are uploading the docs, but the correct manifest is missing. * The relevant call to build-manifest seems to be [in bootstrap](https://github.com/rust-lang/rust/blob/c058a8b8dc5dea0ed9b33e14da9e317e2749fcd7/src/bootstrap/dist.rs#L2334) * The manifest is then used in [promote-release crontab](https://github.com/rust-lang/rust-central-station/blob/master/crontab)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
rust-docscomponent to toolchainx86_64-unknown-linux-musl, which allows people using rustup on their musl-based linux distribution to download the rust-docs.--disable-docsis based on the assumption thatx86_64-unknown-linux-muslis only a cross-compile target.I have tested that the docs are built. I assume the build-system will automatically detect the docs and create a
rust-docscomponent. I will monitor the components and create a follow-up PR, if the docs aren't published.See also #70619, where we enabled
rust-lldto enable the wasm-workflow on musl-based linux distributions.