Explicitly implement !Send and !Sync for sys::{Args, Env}#84179
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 24, 2021
Merged
Explicitly implement !Send and !Sync for sys::{Args, Env}#84179bors merged 1 commit intorust-lang:masterfrom
!Send and !Sync for sys::{Args, Env}#84179bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
Apr 14, 2021
Member
m-ou-se
left a comment
m-ou-se
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me. One typo:
Member
|
@bors r+ |
Collaborator
|
📌 Commit b29a887 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 14, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 14, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
Collaborator
|
⌛ Testing commit b29a887 with merge ef45544547ed2665a9d9d072fa90accc1512038b... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
Author
|
Oops another typo, fixed. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 2ecc820 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
This was referenced Apr 22, 2021
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
Collaborator
|
☔ The latest upstream changes (presumably #84440) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Contributor
Author
|
Rebased and merged. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit dc110af has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 24, 2021
Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`
Remove the field `_dont_send_or_sync_me: PhantomData<*mut ()>` in favor of an explicit implementation of `!Send` and `!Sync`.
This was referenced Apr 24, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#83519 (Implement a lint that highlights all moves larger than a configured limit) - rust-lang#84105 (stabilize `core::array::{from_ref,from_mut}` in `1.53.0`) - rust-lang#84179 (Explicitly implement `!Send` and `!Sync` for `sys::{Args, Env}`) - rust-lang#84427 (Update Clippy) - rust-lang#84459 (rustdoc: Turn `JsonRenderer::mod_item_in` into `unreachable!()`) - rust-lang#84460 (rustdoc: Remove unnecessary `is_crate` field from doctree::Module and clean::Module) - rust-lang#84464 (rustdoc: Get rid of `clean::TypeKind`) - rust-lang#84518 (Clean up DOM strings) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the field
_dont_send_or_sync_me: PhantomData<*mut ()>in favor of an explicit implementation of!Sendand!Sync.