Merged
Conversation
GuillaumeGomez
added
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
Member
|
I'd like this to use the same logic as added by #86152 (once it lands) to make sure we're lazily evaluating the condition here. Otherwise broadly looks good but I'd like to take another look before final r+ once this is updated. |
Mark-Simulacrum
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
html-checker2
branch
from
5148fe9 to
d854183
Compare
GuillaumeGomez
added
S-waiting-on-review
Member
Author
|
Updated! I added the lazy check as well. |
Mark-Simulacrum
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
html-checker2
branch
from
d854183 to
325120f
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
html-checker2
branch
from
325120f to
d0b1443
Compare
Member
Author
|
@bors: r=Mark-Simulacrum |
Collaborator
|
📌 Commit d0b1443f2751e8f956d54155dca37a7c60da9b48 has been approved by |
bors
added
S-waiting-on-bors
Member
|
If you could squash commits that would also be good. |
Member
Author
|
Doing that! @bors: r- |
bors
added
S-waiting-on-author
* Make html-checker run by default on rust compiler docs as well * Ensure html-checker is run on CI * Lazify tidy binary presence check
GuillaumeGomez
force-pushed
the
html-checker2
branch
from
d0b1443 to
785b705
Compare
Member
Author
|
I kept the "specialized" commits on their own, merged the others together. @bors: r=Mark-Simulacrum |
Collaborator
|
📌 Commit 785b705 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#86059 (Add new tool to check HTML) - rust-lang#86529 (Add support for OpenSSL 3.0.0) - rust-lang#86657 (Fix `future_prelude_collision` false positive) - rust-lang#86661 (Editon 2021 enables precise capture) - rust-lang#86671 (Turn non_fmt_panic into a future_incompatible edition lint.) - rust-lang#86673 (Make disjoint_capture_migration an edition lint.) - rust-lang#86678 (Fix garbled suggestion for missing lifetime specifier) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening of #84480.
r? @Mark-Simulacrum