Group commandline tests in a directory#90560
Group commandline tests in a directory#90560vandenheuvel wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
@vandenheuvel please do not remove the rustdoc tests. They test the behavior of rustdoc, not rustc, and we've had regressions where the behavior differs before. |
53af261 to
27893dd
Compare
|
r? @jyn514 |
|
I don't have time to review this right now, sorry. r? rust-lang/compiler |
|
@rustbot label: +S-waiting-on-review |
|
r? rust-lang/compiler |
|
@vandenheuvel please don't reassign people after only a couple days, it can be a while before they have time to review and switching often actually makes it less likely. |
|
@bors r+ rollup |
|
📌 Commit 27893dd has been approved by |
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
|
⌛ Testing commit 27893dd with merge 6e4d0c0ea48ac97ee508ed6dacd490695fc3482e... |
|
💔 Test failed - checks-actions |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
I think this should still be good to merge, as these were removed from #90837. |
|
@bors retry |
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
|
Looks like this failed in a rollup: |
|
Ping from triage: |
|
@JohnCSimon I think this can be merged. Can this be retried once more? |
|
@vandenheuvel the test failure was real, $DIR doesn't work on Windows unfortunately |
I grouped the
ui/command*tests inui/command/argfile/andrustdoc-ui/command*inrustdoc-ui/commandline-argfile/.