Turned all 0x1b_u8.into() into '\x1b' in the docs#91040
Turned all 0x1b_u8.into() into '\x1b' in the docs#91040mahmoud-moursy wants to merge 3 commits intorust-lang:masterfrom
Conversation
Housekeeping to keep docs clean and up to date.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
|
There seem to be more occurrences in https://github.com/rust-lang/rust/blob/master/library/core/src/num/mod.rs like for example: /// let lf = b'\n';
/// let esc = 0x1b_u8;
///
Do you want to turn those into |
They are unnecessary as of Rust 2021 Co-authored-by: r00ster <r00ster91@protonmail.com>
I would love to, but traversing the entirety of Rust's source code to find these instances would take me a lot of time. |
|
@T-O-R-U-S there are actually not that many. Here's what I meant: #91044 |
Turn all 0x1b_u8 into '\x1b' or b'\x1b' Supersedes rust-lang#91040
Turn all 0x1b_u8 into '\x1b' or b'\x1b' Supersedes rust-lang#91040
Turn all 0x1b_u8 into '\x1b' or b'\x1b' Supersedes rust-lang#91040
Turn all 0x1b_u8 into '\x1b' or b'\x1b' Supersedes rust-lang#91040
|
☔ The latest upstream changes (presumably #91064) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing this, since #91044 has already been merged. |
Housekeeping to keep docs clean and up to date -- turned all instances of
0x1b_u8.into()into\x1bwhen I stumbled upon this in the Rust docs.Tested these changes using this code:
It exited and returned code
0.