Implement core::future::lazy#91648
Closed
ibraheemdev wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
3 tasks
Collaborator
|
☔ The latest upstream changes (presumably #91691) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Triage: merge conflicts |
Member
|
@ibraheemdev can you please resolve the merge conflicts? |
Member
|
Ping from triage: |
Member
|
@ibraheemdev Mind making an ACP for this. r=me on the impl if the API gets a second. r? @thomcc |
Member
|
@rustbot author |
Member
Author
|
After thinking about it, I'm not sure there's any benefit of this over an async block and something like #92116 (comment) to access the context. I'm going to close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazyexecutes a closure the first time it is polled:Prior art: https://docs.rs/futures/latest/futures/future/fn.lazy.html
The argument for exposing
task::Contextto the closure is thatlazycan serve as a one-timepoll_fnthat accepts anFnOnce, as opposed to anFnMut. See here for details.(Would a better name be
once?)