Use verbatim paths for process::Command if necessary#92519
Use verbatim paths for process::Command if necessary#92519bors merged 2 commits intorust-lang:masterfrom
process::Command if necessary#92519Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #92580) made this pull request unmergeable. Please resolve the merge conflicts. |
ChrisDenton
force-pushed
the
command-maybe-verbatim
branch
from
c95249c to
2bfd6f8
Compare
joshtriplett
added
the
T-libs-api
|
Seems reasonable to me. @rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
rfcbot
added
the
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
rfcbot
added
to-announce
|
@joshtriplett this can be merged now? |
ChrisDenton
force-pushed
the
command-maybe-verbatim
branch
from
2bfd6f8 to
93f627d
Compare
|
Rebased after #91182 was merged (which didn't cause a merge conflict but does break this PR). The first commit is the same as before. The second fixes |
|
@bors r+ |
|
📌 Commit 93f627d has been approved by |
bors
added
S-waiting-on-bors
… r=dtolnay Use verbatim paths for `process::Command` if necessary In rust-lang#89174, the standard library started using verbatim paths so longer paths are usable by default. However, `Command` was originally left out because of the way `CreateProcessW` was being called. This was changed as a side effect of rust-lang#87704 so now `Command` paths can be converted to verbatim too (if necessary).
Rollup of 6 pull requests Successful merges: - rust-lang#92519 (Use verbatim paths for `process::Command` if necessary) - rust-lang#92612 (Update stdlib for the l4re target) - rust-lang#92663 (Implement `Write for Cursor<[u8; N]>`, plus `A: Allocator` cursor support) - rust-lang#93263 (Consistently present absent stdio handles on Windows as NULL handles.) - rust-lang#93692 (keyword_docs: document use of `in` with `pub` keyword) - rust-lang#94984 (add `CStr` method that accepts any slice containing a nul-terminated string) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fix Windows nightly error caused by rust-lang/rust#92519
…ulacrum [beta] backports This backports/rolls up: * Quick fix for rust-lang#96223. rust-lang#96679 * [beta] Revert rust-lang#92519 on beta rust-lang#96556 * [beta] Clippy backport ICE/infinite loop fix rust-lang#96740 * Revert "Prefer projection candidates instead of param_env candidates for Sized predicates" rust-lang#96593
8 participants
In #89174, the standard library started using verbatim paths so longer paths are usable by default. However,
Commandwas originally left out because of the wayCreateProcessWwas being called. This was changed as a side effect of #87704 so nowCommandpaths can be converted to verbatim too (if necessary).