Some FulfillmentContext-related cleanups#99743
Merged
bors merged 6 commits intorust-lang:masterfrom Aug 6, 2022
Merged
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
fulfillment-context-cleanups
branch
from
f8fcd55 to
0da2bb0
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
fulfillment-context-cleanups
branch
from
0da2bb0 to
89e10d8
Compare
jackh726
approved these changes
Aug 3, 2022
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
couple comments, but r=me otherwise
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Outdated
Show resolved
Hide resolved
Collaborator
|
☔ The latest upstream changes (presumably #100120) made this pull request unmergeable. Please resolve the merge conflicts. |
…rmalize` It spawns up a trait engine, registers the single obligation, then fully solves it
compiler-errors
force-pushed
the
fulfillment-context-cleanups
branch
from
89e10d8 to
f5af266
Compare
Contributor
Author
|
@bors r=jackh726 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (bd04658): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2022
…leanups, r=jackh726 Some `FulfillmentContext`-related cleanups Use `ObligationCtxt` in some places, remove some `FulfillmentContext`s in others... r? types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ObligationCtxtin some places, remove someFulfillmentContexts in others...r? types