Show commit SHA and average request duration per collector#2394
Merged
Kobzol merged 3 commits intorust-lang:masterfrom Feb 11, 2026
Merged
Show commit SHA and average request duration per collector#2394Kobzol merged 3 commits intorust-lang:masterfrom
Kobzol merged 3 commits intorust-lang:masterfrom
Conversation
Jamesbarford
approved these changes
Feb 11, 2026
Contributor
Jamesbarford
left a comment
Jamesbarford
left a comment
There was a problem hiding this comment.
LGTM 👍, couple of questions stemming from curiosity
Member
Author
|
It wasn't trivial to test this locally, so let's see what will happen on the server 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The created date is not very interesting, and doesn't really ever change, so I don't think that we have to show it.
The commit SHA is useful to see on which commit are the collectors at, at the moment.
The average duration is not perfect, because backfilling can mess it up, but in most cases it will be reasonable. It is useful to examine if multiple collectors have a balanced benchmark set.
Closes: #2344