Merged
Conversation
The existing command used is `cp -r -T -- src_dir dst_dir`. But -T doesn't work on Mac. This commit changes it to `cp -r src_dir/. dst_dir`. - Appending the `.` has the same effect as -T: copy the contents of `src_dir` without copy `src_dir` itself. - Also, -R is POSIX but -r is not.
Contributor
Author
|
This came up in rust-lang/rust#53793 (comment), where @toidiu is trying to profile on Mac. For me, it helped, but Cachegrind doesn't run rustc properly and so I end up getting another error further along. Still, seems worth landing. |
Member
|
Thanks! Can't say I'm too familiar with the details myself but this seems fine; we can reimplement the copy in rust if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing command used is
cp -r -T -- src_dir dst_dir. But-T doesn't work on Mac.
This commit changes it to
cp -r src_dir/. dst_dir.Appending the
.has the same effect as -T: copy the contents ofsrc_dirwithout copysrc_diritself.Also, -R is POSIX but -r is not.