fuzz: Add host operations for testing x87_f80#35
Open
tgross35 wants to merge 1 commit intorust-lang:mainfrom
Open
fuzz: Add host operations for testing x87_f80#35tgross35 wants to merge 1 commit intorust-lang:mainfrom
tgross35 wants to merge 1 commit intorust-lang:mainfrom
Conversation
tgross35
force-pushed
the
x87-f80-host
branch
2 times, most recently
from
be3ca92 to
8a4fc55
Compare
Contributor
Author
|
I think this should be reasonable but I don't know this area especially well @quaternic or @programmerjake would you mind checking that the x87 asm is sane? |
| // We need to use fnstenv since there is no way to load only the status word. We | ||
| // take two copies and modify one. | ||
| "fnstenv [{orig_env}]", | ||
| "fnstenv [{env}]", |
Member
There was a problem hiding this comment.
why store the env twice? can't you just read from orig_env and write the new env to env?
Member
There was a problem hiding this comment.
ah, writing twice is easier since the env has a whole bunch of stuff other than status and control words.
Contributor
Author
There was a problem hiding this comment.
Yeah, as far as I know there is no way to set the status register directly without storing the whole thing. But now that I think about it, fstcw followed by fnclex should do all we need, testing...
Member
|
the x87 assembly looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.