Avoid ICE when global_asm const operand fails to evaluate#1467
Merged
bjorn3 merged 1 commit intorust-lang:masterfrom Mar 21, 2024
Merged
Avoid ICE when global_asm const operand fails to evaluate#1467bjorn3 merged 1 commit intorust-lang:masterfrom
bjorn3 merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
With these changes, compiling the test case file: Results in STDERR output: |
Contributor
Author
|
What's standard practice on automated tests for compiler errors like this? I noticed that the test runner in EDIT: I see this is being tracked in issue #381. Makes sense! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1466
Follows the same approach used in rust-lang/rust#122691. The error is reported when calling
const_eval_poly().codegen_global_asm_item()doesn't have a way to propagate the error but can detect theErrorHandled::Reportedcase and avoid the panic.