Preserve partial downloads on network failure #4695
Merged
+46
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@FranciscoTGouveia Looks easy enough! I'll give it a test drive when I'm back with my machine :) |
rami3l
reviewed
Jan 31, 2026
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
Many thanks for investigating into this!
OTOH I do think we need to be more careful about filtering the right kind of error since we do want to redownload if the cache is proven to be corrupted for example 🙏
FranciscoTGouveia
force-pushed
the
download-recover
branch
from
c01dd03 to
235dabb
Compare
rami3l
reviewed
Feb 7, 2026
rami3l
reviewed
Feb 7, 2026
FranciscoTGouveia
force-pushed
the
download-recover
branch
from
235dabb to
1b5abc3
Compare
rami3l
approved these changes
Feb 10, 2026
rami3l
reviewed
Feb 10, 2026
FranciscoTGouveia
force-pushed
the
download-recover
branch
from
3f4542b to
cb889fe
Compare
djc
approved these changes
Feb 11, 2026
FranciscoTGouveia
force-pushed
the
download-recover
branch
from
cb889fe to
17a4b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4448.
If
resume_from_partialis set to true, it short-circuits, ensuring theremove_file(path)is not called.