Adds missing neon intrinsics #1994
Merged
+3,822
−1,475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CrooseGit
force-pushed
the
dev/reucru01/add-missing-intrinsics
branch
from
351e1dd to
798bdbf
Compare
Member
|
LGTM but this needs a rebase. |
- Adds vluti2 intrinsics - Adds famin/famax intrinsics - Adds vstl1(q) intrinsics - Adds vldap1(q) intrinsics - Excludes vldap1_lane_f64 as in testing it fails assert_intr. There seems to be some bad IR gen from rust. - Adds vscale(q) intrinsics - Adds new intrinsics to arm_intrinsics.json - Had to be done manually as intrinsics are not yet on developer.arm.com
Moves the relevant defintions from the aarch64 yaml to the arm_shared.
The opcodes for these intructions are not recognised by the dissasembler on the windows msvc toolchain. As such they are not translated to the relevant mneumonic and the `assert_instr` test fails. Please see [failing test](https://github.com/rust-lang/stdarch/actions/runs/20992978794/job/60342796821?pr=1994#logs).
CrooseGit
force-pushed
the
dev/reucru01/add-missing-intrinsics
branch
from
798bdbf to
468e474
Compare
folkertdev
reviewed
Jan 27, 2026
| doc: "Dot product index form with unsigned and signed integers" | ||
| arguments: ["a: {neon_type[0]}", "b: {neon_type[1]}", "c: {neon_type[2]}"] | ||
| return_type: "{neon_type[0]}" | ||
| big_endian_inverse: true # TODO: Remove this attribute, and replace transmute with vreinterpret when https://github.com/llvm/llvm-project/pull/169337 is merged, LLVM inlining issue causing assertion failure. |
Contributor
There was a problem hiding this comment.
The LLVM 22 bump is in the bors queue now, so this should be very soon
Contributor
There was a problem hiding this comment.
For future reference, use FIXME(llvm22) because those tend to get grepped after the update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some missing arm neon intrinsics to bring stdarch more up-to-date with the acle
Including variants of:
vluti2vaminvamaxvstl1vldap1vldap1_lane_f64as in testing it failsassert_intr. There seems to be some bad IR gen from rust.vscale