Make ArrayBase::get_ptr(_mut) public to enable indexing into raw views.#1151
Merged
jturner314 merged 2 commits intorust-ndarray:0.15.xfrom Jul 30, 2022
adamreichold:pub-get-ptr
Merged
Make ArrayBase::get_ptr(_mut) public to enable indexing into raw views.#1151jturner314 merged 2 commits intorust-ndarray:0.15.xfrom adamreichold:pub-get-ptr
jturner314 merged 2 commits intorust-ndarray:0.15.xfrom
adamreichold:pub-get-ptr
Conversation
Member
|
This looks good to me, although I'd prefer to change the name |
Collaborator
Author
Changed as suggested. |
jturner314
approved these changes
Jan 31, 2022
Member
jturner314
left a comment
jturner314
left a comment
There was a problem hiding this comment.
This looks good to me. I just noticed a minor unnecessary line. I've added this PR to the 0.15.x milestone.
jturner314
reviewed
Jan 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this as we would like to provide raw views into NumPy arrays when it is difficult to enforce the required aliasing guarantees for reference-based views, c.f. PyO3/rust-numpy#260 (comment)
I do wonder whether there is a reason these cannot be made public but could not find anything using Git archaeology.