Update chacha20: use ChaChaCore directly; remove bytes_until_reseed field #1726
+17
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See also this comment: #1686 (comment) |
newpavlov
approved these changes
Feb 2, 2026
Member
Author
|
@newpavlov since this is still blocked by a new chacha20 release can you also review #1727? I'll rebase this after. |
dhardy
force-pushed
the
push-kzkqyroqyklv
branch
3 times, most recently
from
2b89cdd to
683fc27
Compare
newpavlov
reviewed
Feb 2, 2026
dhardy
force-pushed
the
push-kzkqyroqyklv
branch
2 times, most recently
from
a738623 to
34373f0
Compare
newpavlov
reviewed
Feb 5, 2026
dhardy
force-pushed
the
push-kzkqyroqyklv
branch
from
34373f0 to
03db311
Compare
Member
Author
|
Updated. I could put out a new rand RC with this, but I won't bother without a good reason. The chacha20 RC.11 did not bring breaking changes so the current rand RC should still be fine using that. |
Contributor
|
@dhardy I can put out another RC with RustCrypto/stream-ciphers#529 though hopefully it didn't impact anything in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentryDepends on RustCrypto/stream-ciphers#516.