Test lockfile is up-to-date #1739
Merged
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Success: the new test failed. I'll now fix up |
newpavlov
approved these changes
Feb 8, 2026
newpavlov
reviewed
Feb 9, 2026
.github/workflows/test.yml
Outdated
| - uses: actions/checkout@v6 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - run: cargo check --workspace | ||
| - run: test "$(git status --porcelain)" == "" |
Member
There was a problem hiding this comment.
I think we can remove the last command and use cargo check --workspace --locked instead.
Member
Author
There was a problem hiding this comment.
So there is a command for this; well spotted.
Member
There was a problem hiding this comment.
Not quite. It still downloads and checks all dependencies which is a bit redundant in our case.
dhardy
force-pushed
the
push-srpmxmytyyqr
branch
from
378d0c7 to
989872d
Compare
newpavlov
added a commit
to rust-random/getrandom
that referenced
this pull request
Feb 9, 2026
newpavlov
added a commit
to RustCrypto/utils
that referenced
this pull request
Feb 9, 2026
Checks that Cargo.lock was properly updated after repository crate versions were changed. Based on rust-random/rand#1739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trusted-publishing failed recently due to the lockfile being outdated (because the
randversion number inCargo.tomlhad been changed and for whatever reason this must be listed inCargo.locktoo).This test should ensure CI fails before trying to run a publish job should this happen again.
(Alternatively, we could just remove
Cargo.lockfrom version control.)