Run travis tests for 1.22.0 osx, stable on linux, nightly on osx#721
Run travis tests for 1.22.0 osx, stable on linux, nightly on osx#721dhardy merged 1 commit intorust-random:masterfrom
Conversation
Travis supports building on osx, but we aren't running the tests in a few configurations, like OSX with rust 1.22.0, native linux on stable, and OSX on nightly. This adds testers for these situations to make sure that bugs like rust-random#720 don't slip into the system again.
|
As an alternative, libc has a nice setup for multi architecture testing in rust-lang/libc#1233. |
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
We tried to minimise the runners we need, but you are right that we should test more comprehensively. This approach is little extra config which I like; I don't see sufficient motivation to re-write based on the libc setup.
| - rust: nightly | ||
| os: | ||
| - linux | ||
| - osx |
There was a problem hiding this comment.
This could cause a problem: it does a doc-upload at the end. Perhaps you can prefix that:
test "$TRAVIS_OS_NAME" = "linux" && travis-cargo --only nightly doc-upload
|
I know @jcjones was having some trouble with OSX that he hadn't raised as an issue yet: mozilla/authenticator-rs#76 |
|
@jonathanKingston or @jcjones please create a new issue about that. I guess I'll make the suggested change myself and merge this manually. |
|
This doesn't appear to include all the expected builds. Any idea why? |
3 participants
Travis supports building on osx, but we aren't running the tests in a few configurations, like OSX with rust 1.22.0, native linux on stable, and OSX on nightly. This adds testers for these situations to make sure that bugs like #720 don't slip into the system again.