Rename DisplayHandle convenience methods#217
Conversation
To have a consistent naming scheme.
|
I'm still on the fence about this, I think both (I actually think |
|
I think |
|
Agree with @notgull here, same for |
|
But you'd still prefer |
|
The rust naming rule is |
It is, but arguably so is I dunno, we can leave it as-is if that's what y'all perfer. |
|
The crate names we use in winit are |
In #70 (comment), we decided upon a naming scheme for our types, with the main motivation being "consistency" and "
AndroidNDKHandlelooks weird"1.I'm still mostly convinced that this is still the right direction to go in because it matches things like
std::net::Ipv4Addr(if it wasIPv4Addr, then we should've done something different).We should apply this naming scheme to methods as well, in particular
DisplayHandle::appkitandDisplayHandle::uikitneed an extra_to follow normal case-conversion rules.Footnotes
This argument is weakened after https://github.com/rust-windowing/raw-window-handle/pull/214 where this type no longer exists. Now it's only
RawWindowHandle::AndroidNdkvs.RawWindowHandle::AndroidNDK. ↩