Implement core::error::Error when std feature is disabled#221
Merged
Conversation
madsmtm
force-pushed
the
madsmtm/core-error
branch
from
cbb030f to
4e3ceb1
Compare
daxpedda
approved these changes
Mar 27, 2026
This requires a bit higher MSRV, which we document.
kchibisov
force-pushed
the
madsmtm/core-error
branch
from
4e3ceb1 to
551d75c
Compare
kchibisov
force-pushed
the
madsmtm/core-error
branch
from
551d75c to
0662028
Compare
kchibisov
approved these changes
Apr 4, 2026
Member
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
I've bumped MSRV to 1.85 to raise edition to 2024, since we do breaking release anyway no point in holding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires a bit higher MSRV, which we document.
See discussion in rust-windowing/keyboard-types#75 and rust-windowing/keyboard-types#70 for reasoning (basically: MSRV shouldn't hold the nice API back for
no_stdpeople, and the overlap betweenno_std+ low MSRV + windowing is really low).