Use the EXE icon as the window class icon on win32#4472
Open
madd-games wants to merge 6 commits intorust-windowing:masterfrom
Open
Use the EXE icon as the window class icon on win32#4472madd-games wants to merge 6 commits intorust-windowing:masterfrom
madd-games wants to merge 6 commits intorust-windowing:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersWhen registering the window class, we now set
hIconandhIconSmto the icons extracted from the EXE. If they cannot be extracted (e.g. one exists), we are still usingNULL, and so the generic icon would still be applied in this case. Since they are the class icons, they'll be used when we sendWM_SETICONwithNULL- which is when the user callsset_window_icon(None).This change makes sense because the EXE icon logically should be the default, even though windows requires you to load it explicitly. This is done for example by SDL3 on Windows if not icon is set. Furthetmore,
set_window_icondoes nothing on most supported platforms; so setting the icon is almost exclusively a windows-specific call right now. This change will reduce windows-specific boilerplate and headaches.This addresses issue #3932 .