fix: fallback to pk decryption when failed to decrypt with machine uid#486
Open
21pages wants to merge 1 commit intorustdesk:mainfrom
Open
fix: fallback to pk decryption when failed to decrypt with machine uid#48621pages wants to merge 1 commit intorustdesk:mainfrom
21pages wants to merge 1 commit intorustdesk:mainfrom
Conversation
21pages
force-pushed
the
try-fix-password-decrypt
branch
2 times, most recently
from
a00c5a8 to
3650dea
Compare
- Cache machine uid after successful retrieval - Retry when getting machine uid fails - Fallback to pk decryption when failed to decrypt with machine uid Signed-off-by: 21pages <sunboeasy@gmail.com>
21pages
force-pushed
the
try-fix-password-decrypt
branch
from
3650dea to
7fc18b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pk decryption
I found that decrypting with my password failed, but decrypting with the PK worked. So it’s possible that the machine UID failed to be retrieved during a previous encryption, and the PK was used for encryption instead.
The PK is only attempted during the second decryption. In the first attempt, the machine UID is given priority for decryption. If the PK were also used in the first attempt, then the second attempt to retrieve the machine UID would most likely fail as well.
Reproducing the machine UID read failure
On Windows, reading the machine UID may fail when the system is close to shutdown