Closed
Conversation
Contributor
|
Thanks. We don't take into account rustc version mitigations. |
Contributor
|
This seems already fixed ? 👀 Your fork branch seems to be outdated ? Closing as dup |
Contributor
Author
|
I did a git pull --rebase and the patch showed as unapplied. And github says there is a diff. Did you rename the default branch? Yeah that would obviously wreck havok on all existing checkouts... |
Contributor
|
Yeah I think we renamed it at one stage to main I think, many thanks for the effort anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That said, the known risks of miscompilation are actually completely mitigated by rust-lang/rust#99182. So I wonder if we should remove the advisory?