Open
Conversation
Major refactor to switch from FLAC-specific metaflac tool to universal ID3 tag extraction using mutagen library: - Replace metaflac_get_tags() with Track.load_from_file() using mutagen - Support multiple audio formats: .mp3, .flac, .m4a, .ogg, .wav - Extract metadata from ID3 tags with ORIGINALDATE preference - Generate MD5 hash from year_artist_title instead of audio content - Add configurable songs_dir option to TOML configuration - Encode directly from tracks/ to output directory (no intermediate copying) - Update encoding to 60-second mono AAC clips at 128kbps - Add proper error handling for missing tags and unsupported formats Update README.md to reflect new workflow and requirements.
Owner
|
Thank you for taking the time to open a pull request! This feature seems useful, however the code in this pull request is not up to my standards. It looks like this code was written by an LLM, so there is little point in me reviewing it. In most of my repositories I have a I’m not going to merge it in this form, but people who have files in a different format than flac can of course use your fork, and I’m sure they will be grateful for it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with these changes you are not limited to flac files. so you can use mp3 and so on