Skip to content

Fix/missing dist artifacts#473

Open
JLMA-Agentic-Ai wants to merge 8 commits into
ruvnet:mainfrom
JLMA-Agentic-Ai:fix/missing-dist-artifacts
Open

Fix/missing dist artifacts#473
JLMA-Agentic-Ai wants to merge 8 commits into
ruvnet:mainfrom
JLMA-Agentic-Ai:fix/missing-dist-artifacts

Conversation

@JLMA-Agentic-Ai
Copy link
Copy Markdown
Contributor

Key findings:

  • Upstream: ruvnet/RuVector monorepo — package lives at npm/packages/cognitum-gate-wasm/
  • Root cause: prepublishOnly runs build:wasm first (requires Rust + wasm-pack). When that fails silently in a bare publish environment, build:ts (tsup) never executes and clean wipes any prior dist/. The "files": ["dist", ...] field is correct — the build chain just never completed.
  • Fix pushed: All 3 missing dist artifacts committed to fork branch — dist/cjs/index.js (271 lines), dist/esm/index.js (18 lines), dist/types/index.d.ts (65 lines)
  • Recommendation for maintainers: Decouple build:wasm from build:ts so a missing Rust toolchain doesn't block JS/TS compilation

github-actions Bot and others added 8 commits May 11, 2026 14:32
Built from commit ef5274c

Platforms updated:
- linux-x64-gnu
- linux-x64-musl
- linux-arm64-gnu
- linux-arm64-musl
- darwin-x64
- darwin-arm64
- win32-x64-msvc
- wasm

Generated by GitHub Actions
Built from commit ef5274c

Platforms: linux-x64-gnu, linux-arm64-gnu, darwin-x64, darwin-arm64, win32-x64-msvc

Co-Authored-By: claude-flow <ruv@ruv.net>
  Built from commit ef5274c

  Platforms updated:
  - linux-x64-gnu
  - linux-arm64-gnu
  - darwin-x64
  - darwin-arm64
  - win32-x64-msvc

  🤖 Generated by GitHub Actions
Built from commit ef5274c

Platforms updated:
- linux-x64-gnu
- linux-x64-musl
- linux-arm64-gnu
- linux-arm64-musl
- darwin-x64
- darwin-arm64
- win32-x64-msvc

Generated by GitHub Actions
  Built from commit ef5274c

  Platforms updated:
  - linux-x64-gnu
  - linux-arm64-gnu
  - darwin-x64
  - darwin-arm64
  - win32-x64-msvc
  - wasm

  🤖 Generated by GitHub Actions
@ruvnet
Copy link
Copy Markdown
Owner

ruvnet commented May 22, 2026

Thanks for the investigation on the missing dist artifacts. However, I can't merge this PR in its current form for a few reasons:

  1. Incorrect platform mappings: Several GNN binaries appear to be placed in wrong platform directories — e.g. crates/ruvector-gnn-node/npm/linux-arm64-gnu/ruvector-gnn.darwin-arm64.node (darwin binary in a linux dir). The filename suffix does not match the directory.

  2. Binary blobs are unverifiable: Pre-compiled native binaries cannot be code-reviewed for correctness or security. Binary artifacts should be produced by the CI pipeline (GitHub Actions NAPI build matrix), not committed manually, to prevent supply chain risks.

  3. Build process fix is the right approach: The correct fix is to repair the prepublishOnly script so build:ts runs independently of build:wasm, as you identified in the description. That way the CI pipeline generates correct, verifiable binaries.

If you'd like to contribute the build-script decoupling fix (separating WASM build from TS build), that would be a great follow-up PR.

ruvnet added a commit that referenced this pull request May 22, 2026
- Update main/module/types/exports to match tsup flat output structure
  (dist/index.js, dist/index.mjs, dist/index.d.ts) instead of nested
  cjs/esm/types subdirs that never existed
- Change build script: `build:wasm || true && build:ts` so TypeScript
  compilation succeeds even when wasm-pack is unavailable
- Remove phantom sub-path exports (./node, ./sw, ./wasm, ./experimental)
  for files that don't exist in the source tree

Fixes the issue reported in PR #473 where prepublishOnly failed silently
because wasm-pack absence blocked tsup from running.

Co-Authored-By: claude-flow <ruv@ruv.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants