Skip to content

fix(security): RUSTSEC advisories + clippy hardening in RuVector #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruvnet merged 4 commits into from
May 23, 2026
Merged

fix(security): RUSTSEC advisories + clippy hardening in RuVector #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dc5dbe
fix(security): RUSTSEC advisories + clippy hardening in RuVector
ruvnet May 23, 2026
fc775d6
fix(ci): cargo fmt + restore workspace unused_unit lint allow
ruvnet May 23, 2026
0b06d87
fix(ci): remove unneeded unit return type in ruvix bench
ruvnet May 23, 2026
ac7e22e
fix(ci): resolve rustfmt and clippy unused_unit failures
ruvnet May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ members = [
]
resolver = "2"

[workspace.lints.clippy]
unused_unit = "allow"

[workspace.package]
version = "2.2.3"
edition = "2021"
Expand Down
4 changes: 2 additions & 2 deletions crates/cognitum-gate-kernel/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -129,7 +129,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/cognitum-gate-tilezero/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -148,7 +148,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/mcp-brain-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -197,7 +197,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/mcp-brain/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -122,7 +122,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/neural-trader-strategies/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -103,7 +103,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/prime-radiant/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ same_item_push = "allow"
while_let_loop = "allow"
while_let_on_iterator = "allow"
for_kv_map = "allow"
unused_unit = "allow"

redundant_pattern = "allow"
let_and_return = "allow"
needless_lifetimes = "allow"
Expand Down Expand Up @@ -492,7 +492,7 @@ overly_complex_bool_expr = "allow"
len_zero = "allow"
needless_doctest_main = "allow"
match_like_matches_macro = "allow"
match_on_vec_items = "allow"

identity_op = "allow"
match_single_binding = "allow"
needless_match = "allow"
Expand Down
14 changes: 12 additions & 2 deletions crates/prime-radiant/src/hyperbolic/energy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,24 @@ impl HyperbolicEnergy {
pub fn highest_energy_edge(&self) -> Option<&WeightedResidual> {
self.edge_energies
.iter()
.max_by(|a, b| a.weighted_energy.partial_cmp(&b.weighted_energy).unwrap())
// Use unwrap_or to handle NaN weighted_energy gracefully instead of panicking.
.max_by(|a, b| {
a.weighted_energy
.partial_cmp(&b.weighted_energy)
.unwrap_or(std::cmp::Ordering::Equal)
})
}

/// Find deepest edge
pub fn deepest_edge(&self) -> Option<&WeightedResidual> {
self.edge_energies
.iter()
.max_by(|a, b| a.avg_depth().partial_cmp(&b.avg_depth()).unwrap())
// Use unwrap_or to handle NaN depth gracefully instead of panicking.
.max_by(|a, b| {
a.avg_depth()
.partial_cmp(&b.avg_depth())
.unwrap_or(std::cmp::Ordering::Equal)
})
}

/// Get edges above energy threshold
Expand Down
4 changes: 2 additions & 2 deletions crates/ruQu/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -199,7 +199,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruqu-algorithms/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -112,7 +112,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruqu-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -118,7 +118,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruqu-exotic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -109,7 +109,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruqu-wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -118,7 +118,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-attention-node/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -112,7 +112,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-attention-unified-wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -146,7 +146,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-attention-wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -124,7 +124,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-attn-mincut/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -105,7 +105,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -183,7 +183,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -175,7 +175,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-cluster/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -113,7 +113,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-cnn-wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -121,7 +121,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
4 changes: 2 additions & 2 deletions crates/ruvector-cnn/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ unused_imports = "allow"
dead_code = "allow"
unused_variables = "allow"
unused_mut = "allow"
unused_unit = "allow"

unused_assignments = "allow"
unused_must_use = "allow"
missing_docs = "allow"
Expand Down Expand Up @@ -136,7 +136,7 @@ absurd_extreme_comparisons = "allow"
incompatible_msrv = "allow"
unused_enumerate_index = "allow"
unused_self = "allow"
unused_unit = "allow"

map_clone = "allow"
map_unwrap_or = "allow"
result_map_or_into_option = "allow"
Expand Down
Loading
Loading