fix(daemon): prevent self-PID detection from killing background daemon#1485
Open
sasa-tomic wants to merge 1 commit intoruvnet:mainfrom
Open
fix(daemon): prevent self-PID detection from killing background daemon#1485sasa-tomic wants to merge 1 commit intoruvnet:mainfrom
sasa-tomic wants to merge 1 commit intoruvnet:mainfrom
Conversation
In background mode, the forked child process writes its own PID to daemon.pid before calling daemon.start(). checkExistingDaemon() then reads this file, finds the PID is alive (it's checking itself), and returns early thinking another daemon is already running. This skips all worker scheduling, leaving no event-loop refs, so Node.js exits immediately with code 0. Add a self-PID check so the daemon doesn't mistake itself for another running instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkExistingDaemon()readsdaemon.pid(written by the forked child itself), finds the PID alive (it's checking itself viaprocess.kill(pid, 0)), and returns early — skipping all worker schedulingcheckExistingDaemon()so the daemon doesn't mistake itself for another instanceReproduction
With
strace -f, you can see the child process exits withexit_group(0)moments after starting.Fix
One-line guard in
checkExistingDaemon():Test plan
ruflo daemon start→ process stays aliveruflo daemon status→ shows Runningruflo doctor→ Daemon Status passes