fix: prefix bare model names with Xenova/ in all defaults#1517
Open
sparkling wants to merge 2 commits intoruvnet:mainfrom
Open
fix: prefix bare model names with Xenova/ in all defaults#1517sparkling wants to merge 2 commits intoruvnet:mainfrom
sparkling wants to merge 2 commits intoruvnet:mainfrom
Conversation
Bare model names like 'all-mpnet-base-v2' resolve to non-existent HuggingFace repos, causing @xenova/transformers to fail with 401. EmbeddingService silently falls back to mock embeddings, and all semantic search degrades to FNV-1a hash pseudo-embeddings. Files changed: - init/types.ts: DEFAULT, CODEX, FULL option defaults - commands/init.ts: wizard choices, CLI flag defaults - mcp-tools/embeddings-tools.ts: MCP tool enum + handler default - mcp-tools/hooks-tools.ts: status report model name Fixes ruvnet#1516 Co-Authored-By: claude-flow <ruv@ruv.net>
ControllerRegistry created AgentDB with only dbPath. AgentDB fell back to its own default model (MiniLM 384-dim) instead of the configured model from getEmbeddingConfig() (mpnet 768-dim). Co-Authored-By: claude-flow <ruv@ruv.net>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1516
Summary
Bare model names (e.g.
all-mpnet-base-v2) in init defaults resolve to non-existent HuggingFace repos, causing silent fallback to mock embeddings. Everyinit --fulluser gets fake embeddings.init/types.ts: 3 defaults fixed (DEFAULT, CODEX, FULL)commands/init.ts: 6 references fixed (wizard, CLI flags, help)embeddings-tools.ts: 4 references fixed (MCP enum, default, handler)hooks-tools.ts: 1 reference fixed (status model)Test plan
init --fullwritesXenova/all-mpnet-base-v2to embeddings.json (not bare)memory store+memory searchproduces real embeddings (not hash-fallback)Generated with claude-flow