Use typed integer literal so Linux builds under strict overload resolution#8
Open
FeliceMente wants to merge 1 commit into
Open
Use typed integer literal so Linux builds under strict overload resolution#8FeliceMente wants to merge 1 commit into
FeliceMente wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After rux-lang/Rux#136, the overload resolver enforces argument assignability, so an untyped
intliteral passed to anint32parameter no longer resolves.ZerocallsFill(ptr, size, 0)whereFill(..., value: int32), which now fails to compile.Adds the type suffix:
Fill(ptr, size, 0i32). No logic change.This is the Linux counterpart of the same fix in Std (rux-lang/Std#45 / rux-lang/Std#43). The BSD and Illumos packages very likely have the identical
Zero->Fill(..., 0)site and need the same one-line change.