VisionFive2: FreeBSD CFH to Basic#388
Open
dongdigua wants to merge 1 commit into
Open
Conversation
Reviewer's GuideUpdates the VisionFive2 FreeBSD test documentation from a custom 14.3-based CFH flow to a straightforward 15.1-BETA1 image-based flow and marks the platform status as basic, reflecting successful serial-console boot and login in both English and Chinese docs. Sequence diagram for updated VisionFive2 boot via UBoot and FreeBSD loadersequenceDiagram
actor User
participant Board as VisionFive2_board
participant UBoot as UBoot_firmware
participant Loader as FreeBSD_EFI_loader
participant Kernel as FreeBSD_kernel
participant Serial as Serial_console_ttyu0
User->>Board: Insert_microsd_and_power_on
Board->>UBoot: Start_firmware
User->>UBoot: Interrupt_autoboot
User->>UBoot: load_mmc_1_3_fdt_addr_r_dtb
User->>UBoot: load_mmc_1_3_kernel_addr_r_efi
User->>UBoot: bootefi_kernel_addr_r_fdt_addr_r
UBoot->>Loader: Launch_bootriscv64_efi_with_dtb
Loader->>Serial: Initialize_console_ttyS0_115200
Loader->>Kernel: Load_kernel_and_modules
User->>Loader: At_prompt_set_console_comconsole
User->>Loader: boot
Loader->>Kernel: Transfer_control_with_rootfs_ufs_dev_ufs_rootfs
Kernel->>Serial: Print_boot_messages
Kernel->>Kernel: Mount_root_rw_and_start_rc
Kernel->>Serial: Present_login_prompt_ttyu0
User->>Serial: Login_root
Serial->>Kernel: Authenticate_root_session
Kernel-->>User: Provide_shell_on_ttyu0
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In both README files, the DTB path hardcodes
jh7110-starfive-visionfive-2-v1.3b.dtb; consider adding a short note about board revisions or alternative DTBs so users with non‑v1.3b hardware know what to adjust. - The Chinese README section title
### 构建安装镜像no longer matches the new flow (download + unxz + dd rather than building), so renaming it to something like下载并刷写镜像would better reflect the current steps. - You now directly embed the 15.1-BETA1 image URL in multiple places; it might be worth adding a brief one-line note that this is a beta image (and may need updating to the eventual 15.1-RELEASE) to set expectations for users following the guide.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In both README files, the DTB path hardcodes `jh7110-starfive-visionfive-2-v1.3b.dtb`; consider adding a short note about board revisions or alternative DTBs so users with non‑v1.3b hardware know what to adjust.
- The Chinese README section title `### 构建安装镜像` no longer matches the new flow (download + unxz + dd rather than building), so renaming it to something like `下载并刷写镜像` would better reflect the current steps.
- You now directly embed the 15.1-BETA1 image URL in multiple places; it might be worth adding a brief one-line note that this is a beta image (and may need updating to the eventual 15.1-RELEASE) to set expectations for users following the guide.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: dongdigua <dongdigua@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Documentation: