Skip to content

VisionFive2: FreeBSD CFH to Basic#388

Open
dongdigua wants to merge 1 commit into
ruyisdk:mainfrom
dongdigua:patch-1
Open

VisionFive2: FreeBSD CFH to Basic#388
dongdigua wants to merge 1 commit into
ruyisdk:mainfrom
dongdigua:patch-1

Conversation

@dongdigua
Copy link
Copy Markdown

@dongdigua dongdigua commented May 3, 2026

Summary by Sourcery

Documentation:

  • Refresh English and Chinese VisionFive 2 FreeBSD guides to use the official 15.1-BETA1 riscv64 image, updated U-Boot boot commands, and serial console configuration, along with new boot logs and a successful test conclusion.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 3, 2026

Reviewer's Guide

Updates the VisionFive2 FreeBSD test documentation from a custom 14.3-based CFH flow to a straightforward 15.1-BETA1 image-based flow and marks the platform status as basic, reflecting successful serial-console boot and login in both English and Chinese docs.

Sequence diagram for updated VisionFive2 boot via UBoot and FreeBSD loader

sequenceDiagram
  actor User
  participant Board as VisionFive2_board
  participant UBoot as UBoot_firmware
  participant Loader as FreeBSD_EFI_loader
  participant Kernel as FreeBSD_kernel
  participant Serial as Serial_console_ttyu0

  User->>Board: Insert_microsd_and_power_on
  Board->>UBoot: Start_firmware

  User->>UBoot: Interrupt_autoboot
  User->>UBoot: load_mmc_1_3_fdt_addr_r_dtb
  User->>UBoot: load_mmc_1_3_kernel_addr_r_efi
  User->>UBoot: bootefi_kernel_addr_r_fdt_addr_r

  UBoot->>Loader: Launch_bootriscv64_efi_with_dtb
  Loader->>Serial: Initialize_console_ttyS0_115200
  Loader->>Kernel: Load_kernel_and_modules

  User->>Loader: At_prompt_set_console_comconsole
  User->>Loader: boot

  Loader->>Kernel: Transfer_control_with_rootfs_ufs_dev_ufs_rootfs
  Kernel->>Serial: Print_boot_messages
  Kernel->>Kernel: Mount_root_rw_and_start_rc
  Kernel->>Serial: Present_login_prompt_ttyu0

  User->>Serial: Login_root
  Serial->>Kernel: Authenticate_root_session
  Kernel-->>User: Provide_shell_on_ttyu0
Loading

File-Level Changes

Change Details Files
Update VisionFive2 FreeBSD test status and metadata to reflect 15.1-BETA1 basic support instead of 14.3 CFH.
  • Change sys_ver front-matter field from 14.3 to 15.1-BETA1 and status from cfh to basic
  • Refresh last_update date to 2026-05-02
  • Update expected and actual results text to describe successful boot and serial-console login
  • Flip test conclusion from failed to successful in both English and Chinese README files
VisionFive2/FreeBSD/README.md
VisionFive2/FreeBSD/README_zh.md
Replace custom-built 14.3 image workflow with direct download and flashing of the official 15.1-BETA1 riscv64 GENERICSD image.
  • Remove git-based mkvf2img.sh build instructions tied to 14.3-RELEASE
  • Add instructions to wget and unxz the official 15.1-BETA1 riscv64 GENERICSD image
  • Update dd flashing examples to use the decompressed 15.1 image filename
  • Mirror these instruction changes in the Chinese README, including terminology adjustments (e.g., microSD/SD card phrasing)
VisionFive2/FreeBSD/README.md
VisionFive2/FreeBSD/README_zh.md
Adjust U-Boot and FreeBSD bootloader steps to match the 15.1-BETA1 layout and console configuration.
  • Change U-Boot commands from fatload mmc 1:1 to load mmc 1:3, using the newer jh7110 VisionFive2 v1.3b DTB path and kernel_addr_r/fdt_addr_r variables
  • Replace the rootfs geom_uzip/md_image bootloader sequence with a console switch to comconsole per upstream commit reference
  • Clarify that serial console should be used instead of EFI framebuffer for interaction during boot, in both languages
VisionFive2/FreeBSD/README.md
VisionFive2/FreeBSD/README_zh.md
Refresh captured boot logs to show a clean 15.1-BETA1 boot and login sequence on VisionFive2.
  • Replace old 14.3 boot log with a new 15.1-BETA1 log from EFI loader through multi-core bringup, storage, network, and USB initialization
  • Show proper root filesystem mount from ufs:/dev/ufs/rootfs instead of md0.uzip and removal of read-only root/firstboot errors
  • Demonstrate successful root login on ttyu0 via serial console instead of repeated sbi_ecall_handler keyboard errors
  • Provide the same updated boot log content in the Chinese README to stay in sync with the English version
VisionFive2/FreeBSD/README.md
VisionFive2/FreeBSD/README_zh.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In both README files, the DTB path hardcodes jh7110-starfive-visionfive-2-v1.3b.dtb; consider adding a short note about board revisions or alternative DTBs so users with non‑v1.3b hardware know what to adjust.
  • The Chinese README section title ### 构建安装镜像 no longer matches the new flow (download + unxz + dd rather than building), so renaming it to something like 下载并刷写镜像 would better reflect the current steps.
  • You now directly embed the 15.1-BETA1 image URL in multiple places; it might be worth adding a brief one-line note that this is a beta image (and may need updating to the eventual 15.1-RELEASE) to set expectations for users following the guide.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In both README files, the DTB path hardcodes `jh7110-starfive-visionfive-2-v1.3b.dtb`; consider adding a short note about board revisions or alternative DTBs so users with non‑v1.3b hardware know what to adjust.
- The Chinese README section title `### 构建安装镜像` no longer matches the new flow (download + unxz + dd rather than building), so renaming it to something like `下载并刷写镜像` would better reflect the current steps.
- You now directly embed the 15.1-BETA1 image URL in multiple places; it might be worth adding a brief one-line note that this is a beta image (and may need updating to the eventual 15.1-RELEASE) to set expectations for users following the guide.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: dongdigua <dongdigua@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant