a11y: harden dialog, controls, and shortcuts - #21
Closed
rwang23 wants to merge 2 commits into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit remediation
Implements the audit's PR-08 slice for #10.
Verification
npm --global=false ciinapps/theme-managernpm run test:sourcenpm run a11y:check --prefix apps/theme-manager(three consecutive passes; native and fallback dialog keyboard flows, forced colors/reduced motion, axe serious/critical)npm run desktop:check(24 Rust tests; no Rust changes after that check)node --checkfor the renderer and accessibility checkergit diff --checkIndependent acceptance
Pass with risks. The new check drives the real renderer through an isolated Chromium session with a mocked Tauri bridge. A packaged Tauri WebView2/WKWebView run and manual visual inspection at 125/150/200% OS scaling remain separate release QA.
Closes #10