Fix cross-platform browser open, port detection, and Windows planning…#17
Closed
richardliebrecht wants to merge 1 commit intorwliebs:mainfrom
Closed
Conversation
… service - Replace `open` npm package with self-contained cross-platform browser open using execSync fallback chains (rundll32/start/explorer on Windows, open/osascript on macOS, xdg-open + 6 fallbacks on Linux) - Replace Unix-only `lsof` port detection with Node.js net.createServer probe - Replace bash-only dev server spawn with shell: true cross-platform spawn - Auto-detect git-bash on Windows and set CLAUDE_CODE_GIT_BASH_PATH in process.env so Claude Code CLI works via both direct spawn and Agent SDK - Always pass env to Agent SDK query() so git-bash path propagates - Reject dummy API keys (e.g. "test") in credential resolution so the system correctly falls through to CLI auth Co-Authored-By: claude-flow <ruv@ruv.net>
Contributor
|
@richardliebrecht is attempting to deploy a commit to the richardliebrecht-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Took a different approach to fixing the same windows setup/browser opening issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… service
opennpm package with self-contained cross-platform browser open using execSync fallback chains (rundll32/start/explorer on Windows, open/osascript on macOS, xdg-open + 6 fallbacks on Linux)lsofport detection with Node.js net.createServer probe