#157 - Fix for console errors + non-loaded comment editor using touchbased devices in rectangle mode#159
Open
danowar2k wants to merge 1 commit into
Conversation
…sing touchbased devices in rectangle mode
Contributor
|
Thank you for the pull request. It corrects the console error log. However, while testing I found that there are actuially some more console errors that comes up(not because of this change). Hence I have decided to correct as many of them as possible and then release a new version that will have these changes. So you need to wait till them to see your changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #157. The comment editor is preloaded, so the following errors just don't happen, it seems. Before the fix when one selected "select mode" the old rectangle without any attached comments stayed, with the fix a comment-less rectangle is removed.
This probably helps preventing the other errors.
You should probably (easy to say, I know) move to another modern PDF annotation library...? ;-)