Delegate auto-merge to github/create-pull-request in rwx/update-packages-github#388
Open
robinaugh wants to merge 2 commits into
Open
Conversation
…ges-github Bump rwx/update-packages-github to 2.0.3, upgrade the inner github/create-pull-request call to 1.0.7, and pass enable-auto-merge through so auto-merge runs alongside reviewer requests in the package. Drop the local gh pr merge --auto --squash fallback in pull-request-options; the inner package now owns that behavior.
Bring rwx/install-cli, github/install-cli, and git/clone up to their latest published versions so check-packages CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
github/create-pull-request 1.0.7with native auto-merge support.Problem
rwx/update-packages-githubenabled auto-merge by shelling out togh pr merge --auto --squash || truein its ownpull-request-optionstask. Now thatgithub/create-pull-requesthandles auto-merge (and surfaces failures non-silently), the outer package should delegate instead of duplicating the logic.Solution
rwx/update-packages-githubto2.0.3.github/create-pull-request 1.0.7and passenable-auto-merge: ${{ params.enable-auto-merge }}through.gh pr merge --auto --squashfallback frompull-request-options; label logic is unchanged.2.0.3.