This repository was archived by the owner on Oct 19, 2019. It is now read-only.
Modification to return logit in inference_small()#7
Open
Modification to return logit in inference_small()#7
Conversation
|
This should be accepted. I also just stumbled into this, and came to the same conclusion: inference_small doesn't return anything, yet in the cifar example, it's (non-existant) value is assigned to a variable. I'm pretty sure it's just that "return" is missing on the last line of inference_small, before inference_small_config(x, c). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the missing line for returning logit in inference_small().
I added the line at the end of inference_small().