feat(socket): combine Unix socket tests and add edge case coverage #121
+532
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the CI flakiness from the removed unix_named_socket_test by combining the named socket tests (bind/listen/accept/connect) into the existing unix_socket_test.rs binary. Running all socket tests in a single process eliminates scheduler contention that was causing timing-related failures. Changes: - Add phases 13-18 to unix_socket_test.rs for named socket functionality: - Phase 13: Basic server-client with bind/listen/accept/connect - Phase 14: ECONNREFUSED on non-existent path - Phase 15: EADDRINUSE on duplicate bind - Phase 16: Non-blocking accept (EAGAIN) - Phase 17: EISCONN on already-connected socket (validation recommendation) - Phase 18: Accept on non-listener socket (validation recommendation) - Update xtask boot stages to include UNIX_SOCKET_TEST_PASSED marker - Add EISCONN and accept-on-non-listener tests to standalone unix_named_socket_test.rs for manual testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unix_socket_test.rsto fix CI flakinessProblem
The standalone
unix_named_socket_testbinary was causing CI flakiness - different tests would timeout on different runs due to scheduler contention from too many concurrent test processes.Solution
Combine both socketpair tests (phases 1-12) and named socket tests (phases 13-18) into a single binary (
unix_socket_test.rs). This eliminates the concurrent process issue while maintaining full test coverage.New Test Phases
Test plan
🤖 Generated with Claude Code