Added option to filter tweets by hashtag#3
Open
kaesetoast wants to merge 11 commits intoryancramerdesign:masterfrom
Open
Added option to filter tweets by hashtag#3kaesetoast wants to merge 11 commits intoryancramerdesign:masterfrom
kaesetoast wants to merge 11 commits intoryancramerdesign:masterfrom
Conversation
added 11 commits
March 24, 2014 16:18
Owner
|
Thanks for your work here! Seems like some great additions. I will definitely look forward to taking a close look as soon as I've got time to get back into this module for updates. |
Author
|
Glad to here that =) I just realised, that you implemented an iterator for accessing non-markup data, so my getDataArray method might be obsolete. I'll have a look at it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ryan,
for a site I am currently working on, I needed a way to only display tweets that contain a certain hashtag, so I grabbed your great module and modified it to fit my needs.
Since I could not find a way to get the desired results from the twitter API (I tried searching tweets by author and hashtag, but unfortunately, this won't work for tweets older than 7 days), I basically grab all the tweets and send them through a function that does the filtering.
Since I prefered getting the plain data array and letting my template take care of the HTML, I also added a public getDataArray method.
I don't know if this is something you want to include in your module, but if you do, feel free to merge this PR :-)
Anyway, thanks for the great work, I am really happy using PW as my new CMS of choice..