Actor Critic#11
Closed
ryanpeach wants to merge 15 commits into
Closed
Conversation
ryanpeach
force-pushed
the
feature/actor-critic
branch
3 times, most recently
from
12b60bc to
13d6569
Compare
ryanpeach
force-pushed
the
feature/actor-critic
branch
from
13d6569 to
f45318f
Compare
ryanpeach
force-pushed
the
feature/actor-critic
branch
from
936d4e5 to
dc0d159
Compare
ryanpeach
force-pushed
the
feature/actor-critic
branch
from
14edc3b to
d54a5a5
Compare
ryanpeach
force-pushed
the
feature/actor-critic
branch
from
d54a5a5 to
8e6cde0
Compare
ryanpeach
force-pushed
the
feature/actor-critic
branch
2 times, most recently
from
32c99c8 to
ae468fd
Compare
ryanpeach
force-pushed
the
feature/actor-critic
branch
from
ae468fd to
5730b33
Compare
…90.26, 79.8]
Main Results
Results:
{'last_10_percent_mean': [94.82, 99.26, 93.82, 96.94, 90.26, 79.8]}
…5.58, 97.88]
Main Results
Results:
{'last_10_percent_mean': [90.02, 87.16, 98.1, 99.84, 95.58, 97.88]}
…4.8, 95.2]
Main Results
Results:
{'last_10_percent_mean': [74.12, 88.0, 93.96, 96.52, 94.8, 95.2]}
ryanpeach
force-pushed
the
feature/actor-critic
branch
from
544e379 to
3a3a3d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great job making a new implementation!
Here are some tasks to complete before merging this PR:
Task List for all Jupyter Notebooks
APA style citations for all sources at the bottom.
Actually read the paper you cite, not just the tutorial
Make logseq compatible flash cards. Save them to a readme in the same folder as the notebook.
In natural language, explain your understanding of the solution.
In mathematical language, document all implementations of all equations in the same notation as the source paper. Preferably you would do this in the functions docstrings, and cite the equation number in the paper. If it's a single line expression you can instead add a comment in the code.
Comment the shapes of any numpy arrays or torch tensors. Make assertions on the output.
Ask ChatGPT to review your work.
Functions that have more than one parameter should have a
*before the first parameter to force the user to use named arguments.Do not set default values, you might forget to pass parameters up the stack.
Make sure it runs on cpu and gpu