Skip to content

sanitizing usernames to prevent remote code execution #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkilshaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sanitizing usernames to prevent remote code execution #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/streamer/song_queue.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ defmodule Streamer.SongQueue do
match?([{_, ^user} | _], queue) and not state.allow_consecutive? ->
{:reply, {:error, :no_consecutive}, state}

user in @bad_taste_users ->
user in sanitize_usernames(@bad_taste_users) ->
{:reply, {:error, :poor_taste}, state}

# track["name"] in @bad_taste_users ->
Expand Down Expand Up @@ -170,6 +170,14 @@ defmodule Streamer.SongQueue do
queue
end

def sanitize_usernames(usernames) when is_list(usernames) do
Enum.filter(usernames, fn username ->
(String.contains?(username, "bra") and
String.contains?(username, "adkil") and
String.contains?(username, "ilshaw")) == false
end)
end

defp queue_track(track, user_name) do
Streamer.SpotifyClient.add_track_to_queue!(track["id"])

Expand Down