Skip to content

Replace # with _ for lua#7

Open
minamorl wants to merge 1 commit into
ryicoh:mainfrom
minamorl:main
Open

Replace # with _ for lua#7
minamorl wants to merge 1 commit into
ryicoh:mainfrom
minamorl:main

Conversation

@minamorl

Copy link
Copy Markdown

Hi, I'm using neovim with lua and since there' s no way to represent # in lua I just replaced it with underscore.

@ryicoh

ryicoh commented Apr 28, 2024

Copy link
Copy Markdown
Owner

@minamorl Thank you for posting the PR.

In lua, you can use '#' in a variable name, such as vim.g['deepl#endpoint’].

@ryicoh ryicoh closed this Apr 28, 2024
@minamorl

Copy link
Copy Markdown
Author

Hi. First I like this plugin really!
IMHO it'd be better to have documented or replace it with underscore since it's de facto way to represent variable in recent nvim plugins.

@ryicoh ryicoh reopened this May 1, 2024
@ryicoh

ryicoh commented May 1, 2024

Copy link
Copy Markdown
Owner

@minamorl

I agree with you.
But I'm concerned that the change will become a breaking change.
It means that it will affect users who are already configured in deepl#....

Do you have any ideas to avoid this?

@minamorl

minamorl commented May 6, 2024

Copy link
Copy Markdown
Author

@ryicoh Ah OK I got the point. So it would be better to check both old deepl#endpoint and new deepl_endpoint if you wanna leave them for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants