Fix ICE #152204/#149156: ABI check fails for unreachable code #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix ICE when ABI computation fails for monomorphized instances that never reach codegen.
Problem
ICEs because
check_instance_abiusesdelayed_bug, assuming codegen will report the error. But unreachable code is monomorphized without reaching codegen.Fix
Replace
delayed_bugwithemit_errto report the ABI/layout error directly.Includes regression test.
Fixes rust-lang#152204
Fixes rust-lang#149156