Merged
Conversation
Fixes #944 The GUI dependency/setup helper was packaging a remote bash -lc command in a form that returned an empty exit 1 over the bastion tunnel path on Simard. Replace that with explicit command checks that survive the real SSH/tunnel execution path while preserving non-interactive apt setup behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add explicit apt-failure coverage, align GUI docs with actual CLI behavior, and include the real-VM gadugi regression scenario for PR #945. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azlin guiremote dependency setup so apt failures propagate correctly instead of collapsing into the emptyGUI dependency/setup phase failed (exit 1): exit code 1pathazlin gui Simardand make its VNC connection checks fatalvncviewerrequirement,connect --x11behavior,--yescompatibility semantics)Fixes #944.
Scope
rust/crates/azlin/src/cmd_gui.rsrust/crates/azlin-cli/src/lib.rstests/agentic-scenarios/pr-945-gui-setup-regression.yamldocs/GUI_FORWARDING.mddocs-site/advanced/gui-forwarding.mdReal-VM QA evidence
Simardtests/agentic-scenarios/pr-945-gui-setup-regression.yamlgadugi-test validate -f tests/agentic-scenarios/pr-945-gui-setup-regression.yamlgadugi-test run -s pr-945-gui-setup-regression -d tests/agentic-scenarios --timeout 240000outputs/sessions/session_9319adb3-a625-4fce-949a-dc1dae4a2311_2026-04-04T17-53-16-771Z.jsonLaunching VNC viewer (127.0.0.1:5901)...CConn: Connected to host 127.0.0.1 port 5901GUI_SIMARD_CONNECTION_OKRust / CLI validation
cargo test -q -p azlin --bin azlin test_build_dependency_setup_script_is_noninteractivecargo test -q -p azlin --bin azlin test_build_dependency_setup_script_propagates_apt_failurescargo test -q -p azlin --bin azlin test_dependency_setup_runner_uses_outer_timeoutcargo test -q -p azlin --bin azlin test_dependency_setup_nonzero_exit_is_explicit_failurecargo test -q -p azlin-cli --libQuality audit
cmd_gui.rsconnect --x11auto-install,--no-viewer, automaticxauth/ compression claims, generic VNC viewer support, misleading--yeswording)qaudit-postfix-cycle2: cleanqaudit-final-code-review: no remaining merge blockers in PR scopeqaudit-final-reviewer: no remaining merge blockers in PR scopeCI
e3b13768OSSF Scorecardis skipped, and only the twoRust CI/build-and-testjobs are still running