Skip to content

Fix for "Can't resolve 'fs'" - #84

Open
ouroboroscoding wants to merge 2 commits into
ryu1kn:masterfrom
ouroboroscoding:master
Open

Fix for "Can't resolve 'fs'"#84
ouroboroscoding wants to merge 2 commits into
ryu1kn:masterfrom
ouroboroscoding:master

Conversation

@ouroboroscoding

Copy link
Copy Markdown

Added "browser" section to package.json so that csv-writer continues to work with latest version of React/node/npm

…to work with latest version of React/node/npm
@ypresto

ypresto commented Apr 28, 2023

Copy link
Copy Markdown

This PR should not be merged as-is because it changes package metadata. Could you create separate branch for publishing and for PR?

@ypresto

ypresto commented Apr 28, 2023

Copy link
Copy Markdown

Also we need to set csvWriter.fileWriter = by hand to avoid calling fs.writeFile().
It should have a new function which returns JS string (createCsvTextWriter or something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants