GraphQL::Extras::PreloadDefault: preload associations by default#4
Open
Narazaka wants to merge 1 commit intorzane:masterfrom
Open
GraphQL::Extras::PreloadDefault: preload associations by default#4Narazaka wants to merge 1 commit intorzane:masterfrom
Narazaka wants to merge 1 commit intorzane:masterfrom
Conversation
Owner
|
Hey @Narazaka, I'm really sorry I didn't see this PR or get back to you. Life has been busy! This is a pretty interesting feature, which some people might appreciate. What are some of the trade-offs with this approach? How would we go about writing tests for this functionality? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ActiveRecord, I think most of the time you use preload to read in the default relation name.
So I made a custom version of the module that calls preload if the preload option is not false.