Skip to content

[ci-suggested-fix] Using docker hub build hook #60

Open
edify42 wants to merge 4 commits intos12v:masterfrom
edify42:master
Open

[ci-suggested-fix] Using docker hub build hook #60
edify42 wants to merge 4 commits intos12v:masterfrom
edify42:master

Conversation

@edify42
Copy link
Copy Markdown

@edify42 edify42 commented May 14, 2019

WHAT

Be able to inject --build-arg variables from the environment.

WHY

A colleague and myself noticed how the docker images were being pushed on docker hub for this repo from the README.md link. We wanted newer images that could be built directly from the master branch here.

Instead I'd like to propose a number of buildable docker images repositories (e.g. /metricbeat and /filebeat) each pointing to the master branch of this repo.

Within the Docker hub build configuration section, you can declare the environment variables like so:
image

Variables such as BEAT_DOCKER_IMAGE and BEAT_NAME would be defined on the environment. The IMAGE_TAG would need ideally be semver'd in some way...

Relates to the builds of images from this issue

ed kim added 4 commits May 13, 2019 17:22
Signed-off-by: ed kim <edward.kim@fairfaxmedia.com.au>
Signed-off-by: ed kim <edward.kim@fairfaxmedia.com.au>
Signed-off-by: ed kim <edward.kim@fairfaxmedia.com.au>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files           4        4           
  Lines         137      137           
=======================================
  Hits           89       89           
  Misses         42       42           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b214ad0...e57d169. Read the comment docs.

@mumoshu
Copy link
Copy Markdown
Collaborator

mumoshu commented May 14, 2019

Wow! I've never realized that Docker Hub had the build env support!
I'll review this asap. Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants