Simplify documentation and QoS configuration - #1
Merged
Conversation
s2015-turtle
marked this pull request as ready for review
July 21, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
can_qos_depthalias and accept onlycan_rx_qos_depthpull_requestonly while retaining post-mergepushCI onmainMotivation
The README mixed user instructions with internal implementation details, making
the supported configuration and normal operating behavior harder to identify.
The repository has not completed its first rosdistro release, so retaining the
old QoS parameter alias adds ambiguity without providing meaningful release
compatibility.
Validation
git diff --checkcan_qos_depthandlegacy_qosno longer occur in tracked implementation or documentation filesparse_driver_configurationdeclarations and call sites use the updated signature