Clarify CAN bridge dependency - #4
Merged
Merged
Conversation
s2015-turtle
marked this pull request as ready for review
July 23, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
can_msgs/msg/Frametopicsros2_socketcanros2_socketcandependency confined torobstride_examplesWhy
The package manifests already had the intended dependency boundary, but the README and core-facing text made the Hardware Component appear specific to
ros2_socketcan.User impact
Users can install
robstride_ros2_controlwith their preferredcan_msgs/msg/Framebridge. The example and aggregate packages continue to provide the existingros2_socketcanlaunch path.Validation
ros2_socketcanis a direct dependency only inrobstride_examples/package.xmlxmllintgit diff --checkCloses #3