Validate hardware parameters - #8
Merged
Merged
Conversation
s2015-turtle
added
bug
s2015-turtle
marked this pull request as ready for review
July 24, 2026 04:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
can_timeout_ticksbefore converting it touint32_tHardwareInfoparser tests for valid boundaries and invalid valuesWhy
NaN gains or offsets and overflowing watchdog values could pass configuration parsing and reach runtime command generation.
User impact
Valid configurations are unchanged. Invalid configurations now fail hardware initialization with a descriptive error.
Validation
git diff --checkclang-format --dry-run --WerrorCloses #5