Skip to content

Require explicit motor gains - #9

Merged
s2015-turtle merged 2 commits into
mainfrom
safety/require-explicit-control-gains
Jul 24, 2026
Merged

Require explicit motor gains#9
s2015-turtle merged 2 commits into
mainfrom
safety/require-explicit-control-gains

Conversation

@s2015-turtle

Copy link
Copy Markdown
Owner

Summary

  • require kp and kd on every motor-profile Xacro macro
  • preserve the previous example values by passing them explicitly in repository fixtures
  • add parameterized tests proving that omitted gains fail and explicit gains expand
  • document that active gains must be tuned for the robot and are not model defaults

Why

The previous macro defaults could apply active stiffness and damping values without an explicit robot-level decision.

User impact

Existing raw ros2_control joint parameters are unchanged. Users of the profile macros must now provide kp and kd explicitly.

Validation

  • git diff --check
  • XML validation with xmllint
  • Python syntax compilation
  • CI will execute the new Xacro pytest on all supported ROS 2 distributions
  • no local build was run on this machine

Closes #6

@s2015-turtle s2015-turtle added enhancement New feature or request maintenance Refactoring, cleanup, and repository maintenance labels Jul 23, 2026
@s2015-turtle
s2015-turtle marked this pull request as ready for review July 24, 2026 04:57
@s2015-turtle
s2015-turtle merged commit cf73743 into main Jul 24, 2026
5 checks passed
@s2015-turtle
s2015-turtle deleted the safety/require-explicit-control-gains branch July 24, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request maintenance Refactoring, cleanup, and repository maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require explicit Kp and Kd in motor-profile Xacro macros

1 participant