Test2

.coderabbit.yaml

@@ -0,0 +1,142 @@
+# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
+tone_instructions: >-
+  Be respectful, concise, and educational. Assume physicist contributors. Prioritize correctness and
+  safety. Ignore purely stylistic issues and Minor/Trivial/Info items.
+reviews:
+  high_level_summary_instructions: >-
+    Write a concise PR summary for a scientific collaboration.
+
+    Include:
+
+    - Motivation / context
+
+    - Key changes (bullets)
+
+    - Potential risk areas (IO format changes, reconstruction behavior changes, thread-safety,
+    performance)
+
+    - Possible future improvements 
+
+
+    Add an emphasis that AI can make mistakes and use best judgment when reading 
+  estimate_code_review_effort: false
+  suggested_labels: false
+  suggested_reviewers: false
+  in_progress_fortune: false
+  poem: false
+  enable_prompt_for_ai_agents: false
+  path_filters:
+    - '!**/build/**'
+    - '!**/install/**'
+    - '!**/*.root'
+    - '!**/*.pdf'
+    - '!**/*.png'
+    - '!**/*.jpg'
+    - '!**/*.gif'
+    - '!**/*.zip'
+    - '!**/*.tar.gz'
+    - '!**/*.so'
+    - '!**/*.dylib'
+    - '!**/*.a'
+    - '!**/*.o'
+  path_instructions:
+    - path: '**/*.{h,hpp,hxx,hh}'
+      instructions: >-
+        Focus on API clarity/stability, ownership semantics (RAII), and avoiding raw new/delete.
+
+        If interfaces change, ask for compatibility notes and any needed downstream updates.
+
+
+        Only raise Critical or Major findings.  Do not post minor style, formatting, naming, or
+        “nice-to-have” refactors.
+    - path: '**/*.{cc,cpp,cxx,c}'
+      instructions: >-
+        Prioritize correctness, memory safety, error handling, and thread-safety.
+
+        Flag hidden global state, non-const singletons, and unclear lifetime assumptions.
+
+
+        Only raise Critical or Major findings.  Do not post minor style, formatting, naming, or
+        “nice-to-have” refactors.
+    - path: '**/*.C'
+      instructions: Do NOT review these files
+    - path: '**/CMakeLists.txt'
+      instructions: |
+        Check for modern CMake target usage, correct scoping, and avoiding global flags.
+  auto_review:
+    ignore_title_keywords:
+      - WIP
+      - DRAFT
+      - DO NOT MERGE
+      - RFC
+  finishing_touches:
+    unit_tests:
+      enabled: false
+  pre_merge_checks:
+    docstrings:
+      mode: 'off'
+    title:
+      mode: 'off'
+    description:
+      mode: 'off'
+    issue_assessment:
+      mode: 'off'
+    custom_checks:
+      - mode: 'off'
+        name: Test plan present
+        instructions: >
+          Check that the PR description includes a "Testing" or "Test Plan" section with at least
+          one bullet.
+
+          Accept: unit test, integration test, or example macro/validation command.
+      - mode: 'off'
+        name: Physics/reco impact noted (if applicable)
+        instructions: >
+          If the PR changes reconstruction outputs, calibration constants, or simulation behavior,
+
+          ensure the description states expected analysis impact and whether reprocessing is
+          required.
+  tools:
+    swiftlint:
+      enabled: false
+    phpstan:
+      enabled: false
+    phpmd:
+      enabled: false
+    golangci-lint:
+      enabled: false
+    detekt:
+      enabled: false
+    pmd:
+      enabled: false
+chat:
+  art: false
+  integrations:
+    jira:
+      usage: disabled
+    linear:
+      usage: disabled
+knowledge_base:
+  code_guidelines:
+    filePatterns:
+      - CONTRIBUTING.md
+      - docs/**
+      - .github/*.md
+  learnings:
+    scope: global
+  jira:
+    usage: disabled
+code_generation:
+  docstrings:
+    path_instructions:
+      - path: '**/*.{h,hpp,hh,hxx,cc,cpp,cxx,C}'
+        instructions: >-
+          Use Doxygen-style documentation, Link to example caller function if available. ONLY add
+          docstrings where none exist. Do NOT modify, rewrite, or reformat any existing
+          docstrings/comments. If a function already has a docstring (even if incomplete), leave it
+          unchanged.
+issue_enrichment:
+  planning:
+    enabled: false
+    auto_planning:
+      enabled: false

.github/workflows/fix-eof-newline-coderabbit-docstrings.yml

@@ -0,0 +1,106 @@
+name: Fix missing final newline (CodeRabbit docstring PRs)
+
+on:
+  pull_request_target:
+    types: [opened, synchronize, reopened]
+
+permissions:
+  contents: write
+  pull-requests: read
+
+jobs:
+  fix_eof_newline:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Guard - only CodeRabbit docstring PRs from same repo
+        id: guard
+        shell: bash
+        run: |
+          set -euo pipefail
+
+          AUTHOR='${{ github.event.pull_request.user.login }}'
+          BASE_REPO='${{ github.event.pull_request.base.repo.full_name }}'
+          HEAD_REPO='${{ github.event.pull_request.head.repo.full_name }}'
+          TITLE='${{ github.event.pull_request.title }}'
+
+          if [[ "$AUTHOR" != "coderabbitai[bot]" ]]; then
+            echo "run=false" >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          # Safety: only push to branches within the same repo
+          if [[ "$BASE_REPO" != "$HEAD_REPO" ]]; then
+            echo "run=false" >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          # only run for docstring PRs
+          if ! echo "$TITLE" | grep -qi "docstring"; then
+            echo "run=false" >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          echo "run=true" >> "$GITHUB_OUTPUT"
+
+      - name: Checkout PR head
+        if: steps.guard.outputs.run == 'true'
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.ref }}
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          fetch-depth: 0
+
+      - name: Append final newline when missing (changed files only)
+        if: steps.guard.outputs.run == 'true'
+        shell: bash
+        run: |
+          set -euo pipefail
+
+          BASE_SHA="${{ github.event.pull_request.base.sha }}"
+          HEAD_SHA="${{ github.event.pull_request.head.sha }}"
+
+          files=$(git diff --name-only "$BASE_SHA" "$HEAD_SHA" -- \
+            '*.C' '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' || true)
+
+          if [[ -z "${files}" ]]; then
+            echo "No relevant files changed."
+            exit 0
+          fi
+
+          changed=0
+          for f in $files; do
+            [[ -f "$f" ]] || continue
+
+            # For non-empty files: ensure last byte is '\n'
+            if [[ -s "$f" ]]; then
+              last_byte="$(tail -c 1 "$f" || true)"
+              if [[ "$last_byte" != $'\n' ]]; then
+                printf '\n' >> "$f"
+                echo "Fixed EOF newline: $f"
+                changed=1
+              fi
+            fi
+          done
+
+          if [[ "$changed" -eq 0 ]]; then
+            echo "All files already end with a newline."
+            exit 0
+          fi
+
+          git status --porcelain
+          git add -A
+
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+
+          git commit -m "Fix missing final newline in docstring PR"
+
+      - name: Push fix commit back to PR branch
+        if: steps.guard.outputs.run == 'true'
+        shell: bash
+        run: |
+          set -euo pipefail
+          # If no commit was created, pushing will fail; so only push if HEAD is ahead.
+          if git rev-parse HEAD~1 >/dev/null 2>&1; then
+            git push origin "HEAD:${{ github.event.pull_request.head.ref }}"
+          fi

calibrations/calorimeter/calo_cdb/CaloCDB-FilterDatasets.cc

@@ -1,6 +1,10 @@
-#include "filter-datasets.h"
+#include "FilterDatasets.h"
+
+#include <phool/recoConsts.h>
 
 #include <iostream>
+#include <string>
+#include <vector>
 
 int main(int argc, const char* const argv[])
 {
@@ -17,7 +21,7 @@ int main(int argc, const char* const argv[])
 
   const std::string& input_csv = args[1];
   std::string output_dir_path = ".";
-  Bool_t debug = false;
+  bool debug = false;
 
   if (args.size() >= 3)
   {
@@ -28,6 +32,9 @@ int main(int argc, const char* const argv[])
     debug = std::stoi(args[3]);
   }
 
+  recoConsts* rc = recoConsts::instance();
+  rc->set_StringFlag("CDB_GLOBALTAG", "newcdbtag");
+
   FilterDatasets filter(debug);
   filter.process(input_csv, output_dir_path);
 

calibrations/calorimeter/calo_cdb/CaloCDB-GenStatus.cc

@@ -1,6 +1,7 @@
-#include "genStatus.h"
+#include "GenStatus.h"
 
 #include <iostream>
+#include <string>
 #include <vector>
 
 int main(int argc, const char* const argv[])

calibrations/calorimeter/calo_cdb/filter-datasets.cc → calibrations/calorimeter/calo_cdb/FilterDatasets.cc

@@ -1,14 +1,18 @@
 
-#include "filter-datasets.h"
+#include "FilterDatasets.h"
 
 // -- My Utils --
 #include "myUtils.h"
 
-// c++ includes --
+// sPHENIX includes --
+#include <ffamodules/CDBInterface.h>
+#include <phool/recoConsts.h>
+
+#include <RtypesCore.h>
 #include <filesystem>
 #include <fstream>
-#include <iomanip>
 #include <iostream>
+#include <sstream>
 
 FilterDatasets::FilterDatasets(Bool_t debug)
   : m_debug(debug)
@@ -30,21 +34,12 @@ void FilterDatasets::readRunInfo(const std::string &line)
 
 std::string FilterDatasets::getCalibration(const std::string &pl_type, uint64_t iov)
 {
-  if (!uti)
-  {
-    uti = std::make_unique<CDBUtils>();
-  }
-  return uti->getUrl(pl_type, iov);
-}
+  recoConsts *rc = recoConsts::instance();
+  // Update the global timestamp flag for the current run in the loop
+  rc->set_uint64Flag("TIMESTAMP", iov);
 
-int FilterDatasets::setGlobalTag(const std::string &tagname)
-{
-  if (!uti)
-  {
-    uti = std::make_unique<CDBUtils>();
-  }
-  int iret = uti->setGlobalTag(tagname);
-  return iret;
+  // Fetch the calibration URL via CDBInterface
+  return CDBInterface::instance()->getUrl(pl_type);
 }
 
 void FilterDatasets::analyze(const std::string &input, const std::string &outputDir)
@@ -142,8 +137,6 @@ void FilterDatasets::process(const std::string &input, const std::string &output
   std::cout << "Debug: " << ((m_debug) ? "True" : "False") << std::endl;
   std::cout << "#############################" << std::endl;
 
-  setGlobalTag("newcdbtag");
-
   std::filesystem::path input_filepath_obj(input);
   if (!myUtils::readCSV(input_filepath_obj, [this](const std::string &line)
                         { this->readRunInfo(line); }))

calibrations/calorimeter/calo_cdb/filter-datasets.h → calibrations/calorimeter/calo_cdb/FilterDatasets.h

@@ -1,23 +1,16 @@
 #ifndef CALOCDB_FILTERDATASETS_H
 #define CALOCDB_FILTERDATASETS_H
 
-// -- sPHENIX includes --
-#include <sphenixnpc/CDBUtils.h>
-
-// -- ROOT includes --
-#include <RtypesCore.h>
-
 // -- c++ includes --
 #include <map>
-#include <memory>
+#include <cstdint>
 #include <string>
-#include <utility>
 #include <vector>
 
 class FilterDatasets
 {
  public:
-  explicit FilterDatasets(Bool_t debug = false);
+  explicit FilterDatasets(bool debug = false);
 
   void process(const std::string &input, const std::string &output = ".");
 
@@ -26,7 +19,6 @@ class FilterDatasets
   void readRunInfo(const std::string &line);
 
   std::string getCalibration(const std::string &pl_type, uint64_t iov);
-  int setGlobalTag(const std::string &tagname);
 
   std::vector<std::pair<std::string, std::string>> m_runInfo;
   std::map<std::string, int> m_ctr;
@@ -36,9 +28,7 @@ class FilterDatasets
                                       , "CEMC_hotTowers_fracBadChi2", "HCALIN_hotTowers_fracBadChi2", "HCALOUT_hotTowers_fracBadChi2"
                                       , "CEMC_ZSCrossCalib", "HCALIN_ZSCrossCalib", "HCALOUT_ZSCrossCalib"};
 
-  Bool_t m_debug;
-
-  std::unique_ptr<CDBUtils> uti{nullptr};
+  bool m_debug;
 };
 
 #endif